RFR: 8282628: Potential memory leak in sun.font.FontConfigManager.getFontConfig()

David Holmes dholmes at openjdk.java.net
Fri Mar 4 21:34:07 UTC 2022


On Fri, 4 Mar 2022 13:25:12 GMT, Zhengyu Gu <zgu at openjdk.org> wrote:

> Please review this small patch that fixes a potential memory leak that exception return fails to release allocated `cacheDirs`
> 
> Test:
> 
> - [x] jdk_desktop on Linux x86_64

I would have just inlined JNU_CHECK_EXCEPTION and added the cleanup code directly. The additional macro wasn't really necessary and would not really be usable for any kind of general cleanup actions beyond a one-liner.

But it is okay.

Thanks.

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7691


More information about the core-libs-dev mailing list