RFR: 8282628: Potential memory leak in sun.font.FontConfigManager.getFontConfig()

Zhengyu Gu zgu at openjdk.java.net
Fri Mar 4 21:57:58 UTC 2022


On Fri, 4 Mar 2022 21:30:53 GMT, David Holmes <dholmes at openjdk.org> wrote:

> I would have just inlined JNU_CHECK_EXCEPTION and added the cleanup code directly. The additional macro wasn't really necessary and would not really be usable for any kind of general cleanup actions beyond a one-liner.
> 
> But it is okay.
> 
> Thanks.

Thanks for the review, @dholmes-ora .

The macros are used to hide the different syntax of c and c++ to avoid polluting code here, it seems to be a common pattern in client code.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7691


More information about the core-libs-dev mailing list