RFR: 8283411: InflaterInputStream holds on to a temporary byte array of 512 bytes [v2]
Jaikiran Pai
jpai at openjdk.java.net
Sun Mar 20 14:05:58 UTC 2022
> Can I please get a review of this change which handles https://bugs.openjdk.java.net/browse/JDK-8283411?
>
> The commit here moves the temporary byte array from being a member of the class to a local variable within the `skip` method which is the only place where it is used as a temporary buffer.
>
> tier1, tier2, tier3 tests have been run successfully with this change.
Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
Use Alan's suggestion and allocate less than 512 bytes if possible. Plus copyright year fix.
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7875/files
- new: https://git.openjdk.java.net/jdk/pull/7875/files/6bc997fb..f4250e7e
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7875&range=01
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7875&range=00-01
Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
Patch: https://git.openjdk.java.net/jdk/pull/7875.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/7875/head:pull/7875
PR: https://git.openjdk.java.net/jdk/pull/7875
More information about the core-libs-dev
mailing list