RFR: 8283411: InflaterInputStream holds on to a temporary byte array of 512 bytes [v2]
Vyom Tewari
vtewari at openjdk.java.net
Mon Mar 21 06:23:30 UTC 2022
On Sun, 20 Mar 2022 14:05:58 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
>> Can I please get a review of this change which handles https://bugs.openjdk.java.net/browse/JDK-8283411?
>>
>> The commit here moves the temporary byte array from being a member of the class to a local variable within the `skip` method which is the only place where it is used as a temporary buffer.
>>
>> tier1, tier2, tier3 tests have been run successfully with this change.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>
> Use Alan's suggestion and allocate less than 512 bytes if possible. Plus copyright year fix.
Looks ok.
-------------
Marked as reviewed by vtewari (Committer).
PR: https://git.openjdk.java.net/jdk/pull/7875
More information about the core-libs-dev
mailing list