RFR: 8253569: javax.xml.catalog.Catalog.matchURI() implementation should reset state variables
Naoto Sato
naoto at openjdk.java.net
Tue Mar 29 21:45:40 UTC 2022
On Tue, 29 Mar 2022 16:39:50 GMT, Joe Wang <joehw at openjdk.org> wrote:
> Resets state of a Catalog instance on each matching call so that it can be reused. Adjusts CatalogResolver's resolve routine so that it continues to observes the PREFER feature in a resolution process. Without the adjustment, PreferFeatureTest would fail.
>
> Mach5 XML tests passed: https://mach5.us.oracle.com/mdash/jobs/huizwang-open-20220329-0148-30563542
src/java.xml/share/classes/javax/xml/catalog/GroupEntry.java line 44:
> 42:
> 43: //Indicates whether this is the Catalog instance (vs a Catalog entry)
> 44: boolean isCatalogInstance = false;
Can we eliminate this instance variable, by checking whether the type is `Catalog` or not in `resetOnStart()`?
-------------
PR: https://git.openjdk.java.net/jdk/pull/8018
More information about the core-libs-dev
mailing list