RFR: 8253569: javax.xml.catalog.Catalog.matchURI() implementation should reset state variables [v2]

Joe Wang joehw at openjdk.java.net
Wed Mar 30 00:46:52 UTC 2022


On Tue, 29 Mar 2022 21:41:52 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Joe Wang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove variable, check instance instead.
>
> src/java.xml/share/classes/javax/xml/catalog/GroupEntry.java line 44:
> 
>> 42: 
>> 43:     //Indicates whether this is the Catalog instance (vs a Catalog entry)
>> 44:     boolean isCatalogInstance = false;
> 
> Can we eliminate this instance variable, by checking whether the type is `Catalog` or not in `resetOnStart()`?

Yes, thanks!

-------------

PR: https://git.openjdk.java.net/jdk/pull/8018


More information about the core-libs-dev mailing list