RFR: 8285295: Need better testing for IdentityHashMap [v4]

[Lance Andersen]

On Wed, 4 May 2022 19:16:14 GMT, Stuart Marks <smarks at openjdk.org> wrote:

>> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch in the bug report that breaks `IdentityHashMap` now causes several cases in this new test to fail. There's more that could be done, but the new tests cover most of the core functions of `IdentityHashMap`. Unfortunately it seems difficult to merge this with the existing, comprehensive Collections tests (e.g., MOAT.java) because those tests implicity rely on `equals()`-based contract instead of the special-purpose `==`-based contract used by `IdentityHashMap`.
>
> Stuart Marks has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add some assertions for entrySet.equals and keySet.equals

I think you have done a nice job on the coverage.

It would be nice for future maintainers if you consider adding comments for all of the tests vs. a subset prior to pushing

-------------

Marked as reviewed by lancea (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8354