RFR: 8285295: Need better testing for IdentityHashMap [v4]

Stuart Marks smarks at openjdk.java.net
Fri May 6 18:45:36 UTC 2022


On Fri, 6 May 2022 16:59:16 GMT, Lance Andersen <lancea at openjdk.org> wrote:

>> Stuart Marks has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add some assertions for entrySet.equals and keySet.equals
>
> I think you have done a nice job on the coverage.
> 
> It would be nice for future maintainers if you consider adding comments for all of the tests vs. a subset prior to pushing

Thanks @LanceAndersen I've added some comments.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8354


More information about the core-libs-dev mailing list