RFR: 8285295: Need better testing for IdentityHashMap [v5]
Stuart Marks
smarks at openjdk.java.net
Fri May 6 18:45:36 UTC 2022
> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch in the bug report that breaks `IdentityHashMap` now causes several cases in this new test to fail. There's more that could be done, but the new tests cover most of the core functions of `IdentityHashMap`. Unfortunately it seems difficult to merge this with the existing, comprehensive Collections tests (e.g., MOAT.java) because those tests implicity rely on `equals()`-based contract instead of the special-purpose `==`-based contract used by `IdentityHashMap`.
Stuart Marks has updated the pull request incrementally with one additional commit since the last revision:
Add comments on tests that were missing them.
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/8354/files
- new: https://git.openjdk.java.net/jdk/pull/8354/files/4bb25edf..fb877d93
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=8354&range=04
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=8354&range=03-04
Stats: 19 lines in 1 file changed: 19 ins; 0 del; 0 mod
Patch: https://git.openjdk.java.net/jdk/pull/8354.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/8354/head:pull/8354
PR: https://git.openjdk.java.net/jdk/pull/8354
More information about the core-libs-dev
mailing list