Integrated: 8285295: Need better testing for IdentityHashMap
Stuart Marks
smarks at openjdk.java.net
Fri May 6 18:45:37 UTC 2022
On Fri, 22 Apr 2022 03:37:27 GMT, Stuart Marks <smarks at openjdk.org> wrote:
> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch in the bug report that breaks `IdentityHashMap` now causes several cases in this new test to fail. There's more that could be done, but the new tests cover most of the core functions of `IdentityHashMap`. Unfortunately it seems difficult to merge this with the existing, comprehensive Collections tests (e.g., MOAT.java) because those tests implicity rely on `equals()`-based contract instead of the special-purpose `==`-based contract used by `IdentityHashMap`.
This pull request has now been integrated.
Changeset: 5a1d8f7e
Author: Stuart Marks <smarks at openjdk.org>
URL: https://git.openjdk.java.net/jdk/commit/5a1d8f7e5358d823e9bdeab8056b1de2b050f939
Stats: 678 lines in 1 file changed: 678 ins; 0 del; 0 mod
8285295: Need better testing for IdentityHashMap
Reviewed-by: jpai, lancea
-------------
PR: https://git.openjdk.java.net/jdk/pull/8354
More information about the core-libs-dev
mailing list