RFR: 8286559: Re-examine synchronization of mark and reset methods on InflaterInputStream
Jaikiran Pai
jpai at openjdk.java.net
Wed May 11 10:23:40 UTC 2022
On Wed, 11 May 2022 09:00:17 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
> Can I please get a review of this change that addresses https://bugs.openjdk.java.net/browse/JDK-8286559?
>
> The commit here removes the `synchronized` on `mark` and `reset` methods of `InflaterInputStream`. The `mark` method is a no-op method and the `reset` method only always throws a `IOException`. So `synchronized` isn't adding any value here.
>
> Additionally, the commit does a minor change to the javadoc of these methods to use `@implNote` to describe what the implementation does. Please let me know if the `@implNote` is unnecessary, in which case, I'll revert that part.
>
> This change is similar to what was recently done for `FilterInputStream` https://github.com/openjdk/jdk/pull/8309 and `PushbackInputStream` https://github.com/openjdk/jdk/pull/8433
>
> tier1, tier2 and tier3 tests were run and no related failures were noticed.
Hello Lance, thank you for the review. I have created a CSR for this now - https://bugs.openjdk.java.net/browse/JDK-8286579
-------------
PR: https://git.openjdk.java.net/jdk/pull/8649
More information about the core-libs-dev
mailing list