RFR: 8286559: Re-examine synchronization of mark and reset methods on InflaterInputStream [v2]
Jaikiran Pai
jpai at openjdk.java.net
Fri May 13 07:14:30 UTC 2022
> Can I please get a review of this change that addresses https://bugs.openjdk.java.net/browse/JDK-8286559?
>
> The commit here removes the `synchronized` on `mark` and `reset` methods of `InflaterInputStream`. The `mark` method is a no-op method and the `reset` method only always throws a `IOException`. So `synchronized` isn't adding any value here.
>
> Additionally, the commit does a minor change to the javadoc of these methods to use `@implNote` to describe what the implementation does. Please let me know if the `@implNote` is unnecessary, in which case, I'll revert that part.
>
> This change is similar to what was recently done for `FilterInputStream` https://github.com/openjdk/jdk/pull/8309 and `PushbackInputStream` https://github.com/openjdk/jdk/pull/8433
>
> tier1, tier2 and tier3 tests were run and no related failures were noticed.
Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
Incorporate review comment made on CSR by Joe - Change @implNote to @implSpec
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/8649/files
- new: https://git.openjdk.java.net/jdk/pull/8649/files/89de6078..4d406ac0
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=8649&range=01
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=8649&range=00-01
Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
Patch: https://git.openjdk.java.net/jdk/pull/8649.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/8649/head:pull/8649
PR: https://git.openjdk.java.net/jdk/pull/8649
More information about the core-libs-dev
mailing list