RFR: 8286681: ShenandoahControlThread::request_gc misses the case of GCCause::_codecache_GC_threshold

[Alan Bateman]

On Fri, 13 May 2022 06:47:20 GMT, Jie Fu <jiefu at openjdk.org> wrote:

>> test/jdk/java/foreign/TestIntrinsics.java line 48:
>> 
>>> 46:  *   -XX:+UseShenandoahGC
>>> 47:  *   TestIntrinsics
>>> 48:  */
>> 
>> Is this needed? The parameters looks the same as the first test description so if you are testing with +ShenandoahGC then it will run already.
>
> Without `-XX:+UseShenandoahGC`, this bug wouldn't be exposed.
> 
> What do you mean by `if you are testing with +ShenandoahGC then it will run already`?

I assume you are running the tests with:
   make run-tests TEST_OPTS_JAVA_OPTIONS="-XX:+UseShenandoahGC" 
in which case, all of the tests you select to run will be run with that GC. 

What you have is not wrong but wouldn't be a better to add a new test to test/hotspot/jtreg/gc rather than relying on test in test/jdk/java/foreign?

-------------

PR: https://git.openjdk.java.net/jdk/pull/8691