RFR: 8286681: ShenandoahControlThread::request_gc misses the case of GCCause::_codecache_GC_threshold
Jie Fu
jiefu at openjdk.java.net
Fri May 13 07:16:39 UTC 2022
On Fri, 13 May 2022 06:56:23 GMT, Alan Bateman <alanb at openjdk.org> wrote:
> I assume you are running the tests with: make run-tests TEST_OPTS_JAVA_OPTIONS="-XX:+UseShenandoahGC" in which case, all of the tests you select to run will be run with that GC.
Yes, you're right.
> What you have is not wrong but wouldn't be a better to add a new test to test/hotspot/jtreg/gc rather than relying on test in test/jdk/java/foreign?
I would suggest reusing the existing test in java/foreign.
This is because this bug was first triggered after `Implementation of Foreign Function & Memory API (Preview)` integration.
And I don't want a copy-paste code duplication in a new test file.
Thanks.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8691
More information about the core-libs-dev
mailing list