RFR: 8286810: Use public [Double|Float].PRECISION fields in jdk.internal.math.[Double|Float]Consts

Roger Riggs rriggs at openjdk.java.net
Mon May 16 15:46:49 UTC 2022


On Mon, 16 May 2022 14:48:43 GMT, Raffaello Giulietti <duke at openjdk.java.net> wrote:

> Please review these simple changes in jdk.internal.math.[Double|Float]Consts

src/java.base/share/classes/jdk/internal/math/DoubleConsts.java line 28:

> 26: package jdk.internal.math;
> 27: 
> 28: import static java.lang.Double.*;

I'd rather see explicit static imports, especially if there is any ambiguity as to where they come from.
When using ordinary text search in a file, it can quickly identify a static import as the source of the symbol.
As in this case where the same symbol has different values for Float vs Double. YMMV

-------------

PR: https://git.openjdk.java.net/jdk/pull/8729


More information about the core-libs-dev mailing list