RFR: 8286810: Use public [Double|Float].PRECISION fields in jdk.internal.math.[Double|Float]Consts [v2]

Brian Burkhalter bpb at openjdk.java.net
Mon May 16 15:54:27 UTC 2022


On Mon, 16 May 2022 15:43:45 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8286810: Use public [Double|Float].PRECISION fields in jdk.internal.math.[Double|Float]Consts
>
> src/java.base/share/classes/jdk/internal/math/DoubleConsts.java line 28:
> 
>> 26: package jdk.internal.math;
>> 27: 
>> 28: import static java.lang.Double.*;
> 
> I'd rather see explicit static imports, especially if there is any ambiguity as to where they come from.
> When using ordinary text search in a file, it can quickly identify a static import as the source of the symbol.
> As in this case where the same symbol has different values for Float vs Double. YMMV

I concur.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8729


More information about the core-libs-dev mailing list