RFR: 8286825: Linker naming cleanup

[Maurizio Cimadamore]

On Wed, 18 May 2022 16:54:06 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

> This patch is a batch naming cleanup for the foreign linker implementation.
> 
> The naming changes are as follows:
> 
>   - ProgrammableInvoker -> DowncallLinker
>   - ProgrammableUpcallHandler -> UpcallLinker
>   - 'native invoker' -> 'downcall stub'
>   - 'optimzed entry blob' -> 'upcall stub'
>   - OptimizedEntryBlob -> UpcallStub
>   - optimized_entry_frame -> upcall_stub_frame
> 
> Then renaming of some hotspot files:
> 
>   - universalNativeInvoker* -> downcallLinker*
>   - universalUpcallHandler* -> upcallLinker*
>   - foreign_globals* -> foreignGlobals* (to match existing convention)
>   
> Method, field, and other variable names are also adjusted accordingly.

Looks good - I spotted a potential issue in the risc-v port

src/hotspot/cpu/riscv/upcallLinker_riscv.cpp line 30:

> 28: #include "utilities/debug.hpp"
> 29: 
> 30: address UpcallLinker::generate_optimized_upcall_stub(jobject receiver, Method* entry,

Hasn't "generated_optimized_upcall_stub" changed too?

src/hotspot/cpu/riscv/upcallLinker_riscv.cpp line 38:

> 36:   ShouldNotCallThis();
> 37:   return nullptr;
> 38: }

Missing newline (this was here before)

-------------

PR: https://git.openjdk.java.net/jdk/pull/8777