RFR: 8287430 MemorySessionImpl::addOrCleanupIfFail does not rethrow exceptions
Jorn Vernee
jvernee at openjdk.java.net
Fri May 27 18:01:35 UTC 2022
On Fri, 27 May 2022 10:29:14 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
> This patch fix a missing rethrow in `MemorySessionImpl::addOrCleanupIfFail`. As noted in the JBS issue, this bug does not affect correctness, but it delays error reporting.
>
> Writing a test for this is nearly impossible, given that (a) a memory resource created against a closed session would be inaccessible by clients (because the session is closed!), and (b) because of the narrow window in which the problem might manifest (for this problem to occur, a session state change would have to occur between the first state check and when the cleanup action list is updated).
Marked as reviewed by jvernee (Reviewer).
-------------
PR: https://git.openjdk.java.net/jdk/pull/8917
More information about the core-libs-dev
mailing list