Integrated: 8287430 MemorySessionImpl::addOrCleanupIfFail does not rethrow exceptions
Maurizio Cimadamore
mcimadamore at openjdk.java.net
Mon May 30 15:43:48 UTC 2022
On Fri, 27 May 2022 10:29:14 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
> This patch fix a missing rethrow in `MemorySessionImpl::addOrCleanupIfFail`. As noted in the JBS issue, this bug does not affect correctness, but it delays error reporting.
>
> Writing a test for this is nearly impossible, given that (a) a memory resource created against a closed session would be inaccessible by clients (because the session is closed!), and (b) because of the narrow window in which the problem might manifest (for this problem to occur, a session state change would have to occur between the first state check and when the cleanup action list is updated).
This pull request has now been integrated.
Changeset: 0c420e03
Author: Maurizio Cimadamore <mcimadamore at openjdk.org>
URL: https://git.openjdk.java.net/jdk/commit/0c420e03ae24144a8146edb39f546841da33e381
Stats: 9 lines in 1 file changed: 3 ins; 0 del; 6 mod
8287430: MemorySessionImpl::addOrCleanupIfFail does not rethrow exceptions
Reviewed-by: jvernee
-------------
PR: https://git.openjdk.java.net/jdk/pull/8917
More information about the core-libs-dev
mailing list