RFR: 8296154: [macos] Change "/Applications" to "Applications" in DMG image [v2]

Alexander Matveev almatvee at openjdk.org
Sat Nov 5 01:08:12 UTC 2022


On Fri, 4 Nov 2022 23:44:15 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:

>> Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8296154: [macos] Change /Applications to Applications in DMG image [v2]
>
> src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacBaseInstallerBundler.java line 121:
> 
>> 119:     // use "Applications" or "JavaVirtualMachines". For user provided installation
>> 120:     // directory we will use full path as display name.
>> 121:     static String getInstallDirDisplayName(
> 
> Is this method ever called with `false` as the last parameter? If no, I'd remove it.

No, it does not. I removed it.

-------------

PR: https://git.openjdk.org/jdk/pull/11001


More information about the core-libs-dev mailing list