RFR: 8296154: [macos] Change /Applications to Applications in DMG image

Alexey Semenyuk asemenyuk at openjdk.org
Fri Nov 4 23:46:26 UTC 2022


On Fri, 4 Nov 2022 23:26:00 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:

> Changed names of symbolic links for drag and drop location in DMG image. See attached images in JBS.
> "/Applications" -> "Applications" for app DMG image.
> "/Library/Java/JavaVirtualMachines" -> "JavaVirtualMachines" for runtime DMG image.
> 
> Automated test was not added, since DMGsetup.scpt is not getting executed in headless environment and thus symbolic links are not created during automated testing.

src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacBaseInstallerBundler.java line 121:

> 119:     // use "Applications" or "JavaVirtualMachines". For user provided installation
> 120:     // directory we will use full path as display name.
> 121:     static String getInstallDirDisplayName(

Is this method ever called with `false` as the last parameter? If no, I'd remove it.

-------------

PR: https://git.openjdk.org/jdk/pull/11001


More information about the core-libs-dev mailing list