RFR: JDK-8297731: Remove redundant check in MutableBigInteger.divide
Sergey Bylokhov
serb at openjdk.org
Mon Nov 28 20:08:00 UTC 2022
On Mon, 28 Nov 2022 19:56:23 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:
>> src/java.base/share/classes/java/math/MutableBigInteger.java line 1536:
>>
>>> 1534:
>>> 1535: // Must insert leading 0 in rem if its length did not change
>>> 1536: if (rem.intLen == nlen) {
>>
>> Looks like after this change the local nlen variable is used only once, and probably can be removed?
>
> BTW the "rem.leftShift(shift);" above may change the "rem.intLen" value, no?
Sorry I have looked into the different method=), -> divideLongMagnitude.
-------------
PR: https://git.openjdk.org/jdk/pull/11395
More information about the core-libs-dev
mailing list