RFR: JDK-8297731: Remove redundant check in MutableBigInteger.divide
Andrey Turbanov
aturbanov at openjdk.org
Tue Nov 29 07:42:26 UTC 2022
On Mon, 28 Nov 2022 18:58:29 GMT, Joe Darcy <darcy at openjdk.org> wrote:
> Remove redundant code reported in
>
> https://mail.openjdk.org/pipermail/core-libs-dev/2022-November/097163.html
IDEA now highlights unnecessary `rem.offset=1` assignments, which are above modified code.
Now we always overwrite it with `0` anyway.
https://github.com/openjdk/jdk/blob/6f06f440bcf8a5db379b80e8765af38a15449356/src/java.base/share/classes/java/math/MutableBigInteger.java#L1498
https://github.com/openjdk/jdk/blob/6f06f440bcf8a5db379b80e8765af38a15449356/src/java.base/share/classes/java/math/MutableBigInteger.java#L1504
https://github.com/openjdk/jdk/blob/6f06f440bcf8a5db379b80e8765af38a15449356/src/java.base/share/classes/java/math/MutableBigInteger.java#L1520
Perhaps we can drop them too.
-------------
PR: https://git.openjdk.org/jdk/pull/11395
More information about the core-libs-dev
mailing list