RFR: 8294989: ResourceBundle naming convention issue in JdbcRowSetResourceBundle.java [v8]
Justin Lu
duke at openjdk.org
Fri Oct 21 18:56:51 UTC 2022
On Fri, 21 Oct 2022 18:03:27 GMT, Lance Andersen <lancea at openjdk.org> wrote:
>> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Pass exception to constuctor directly
>
> test/jdk/javax/sql/testng/test/rowset/ValidateResourceBundleAccess.java line 41:
>
>> 39: public class ValidateResourceBundleAccess{
>> 40: // Expected JDBCResourceBundle message, jdbcrowsetimpl.invalstate
>> 41: private static final String invalidState = "Invalid state";
>
> Please make the constant names upper case
Missed that, made the fix, thank you
-------------
PR: https://git.openjdk.org/jdk/pull/10612
More information about the core-libs-dev
mailing list