RFR: 8294989: ResourceBundle naming convention issue in JdbcRowSetResourceBundle.java [v12]

Justin Lu duke at openjdk.org
Mon Oct 24 16:37:56 UTC 2022


> Issue: Resource bundle name does not follow proper naming conventions according to [getBundle method](https://docs.oracle.com/en/java/javase/18/docs/api/java.base/java/util/ResourceBundle.html#getBundle(java.lang.String,java.util.Locale,java.lang.Module)) for base name parameter
> 
> Fix: Modified bundle name to be a fully qualified class and added regression tests.

Justin Lu has updated the pull request incrementally with one additional commit since the last revision:

  Use data provider for getBundle test

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/10612/files
  - new: https://git.openjdk.org/jdk/pull/10612/files/8f0b6ac6..0f503392

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=10612&range=11
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10612&range=10-11

  Stats: 25 lines in 1 file changed: 16 ins; 7 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/10612.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10612/head:pull/10612

PR: https://git.openjdk.org/jdk/pull/10612


More information about the core-libs-dev mailing list