RFR: 8294989: ResourceBundle naming convention issue in JdbcRowSetResourceBundle.java [v12]

Lance Andersen lancea at openjdk.org
Mon Oct 24 18:36:32 UTC 2022


On Mon, 24 Oct 2022 16:37:56 GMT, Justin Lu <duke at openjdk.org> wrote:

>> Issue: Resource bundle name does not follow proper naming conventions according to [getBundle method](https://docs.oracle.com/en/java/javase/18/docs/api/java.base/java/util/ResourceBundle.html#getBundle(java.lang.String,java.util.Locale,java.lang.Module)) for base name parameter
>> 
>> Fix: Modified bundle name to be a fully qualified class and added regression tests.
>
> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use data provider for getBundle test

Hi Justin,

I think you are in good shape regardless of what you decide/prefer to do with the DataProvider with or without constants.

thank you for your efforts here

-------------

Marked as reviewed by lancea (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10612


More information about the core-libs-dev mailing list