RFR: 8294989: ResourceBundle naming convention issue in JdbcRowSetResourceBundle.java [v12]

[Lance Andersen]

On Mon, 24 Oct 2022 17:54:20 GMT, Brent Christian <bchristi at openjdk.org> wrote:

>> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use data provider for getBundle test
>
> test/jdk/javax/sql/resourceBundleTests/ValidateGetBundle.java line 81:
> 
>> 79:                 Arguments.of(PATH_TO_BUNDLE, false)
>> 80:         );
>> 81:     }
> 
> I think the literals can be used in `bundleProvider` - no need to define constants.
> Also, `@DataProvider`s are typically located towards the beginning of the file.

I am fine with the constants as I find it easier to see/modify/document than within the DataProvider.

This is really a style choice so your milage may vary :-)

-------------

PR: https://git.openjdk.org/jdk/pull/10612