RFR: 8289613: Drop use of Thread.stop in jshell [v3]

Adam Sotona asotona at openjdk.org
Tue Sep 6 12:19:48 UTC 2022


On Tue, 6 Sep 2022 08:06:13 GMT, Rémi Forax <forax at openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - allStop field and stopCheck method moved to synthetic REPL.$Cancel$
>>  - Revert "alternative implementation where instrumented code is directly checking Thread::interrupted"
>>    
>>    This reverts commit 0f0e0dd17c121955e7806073bb8cc78da1f133ea.
>
> src/jdk.jshell/share/classes/jdk/jshell/execution/LocalExecutionControl.java line 119:
> 
>> 117:     protected String invoke(Method doitMethod) throws Exception {
>> 118:         if (allStop == null) {
>> 119:             super.load(new ClassBytecodes[]{genCancelClass()});
> 
> fomatting: usually, people use spaces like this
> 
>   new ClassBytecodes[] {  genCancelClass()  }

Fixed, thanks

-------------

PR: https://git.openjdk.org/jdk/pull/10166


More information about the core-libs-dev mailing list