RFR: 8289613: Drop use of Thread.stop in jshell [v3]

Adam Sotona asotona at openjdk.org
Thu Sep 8 08:40:00 UTC 2022


On Tue, 6 Sep 2022 09:05:53 GMT, Adam Sotona <asotona at openjdk.org> wrote:

>> src/jdk.jshell/share/classes/jdk/jshell/execution/LocalExecutionControl.java line 200:
>> 
>>> 198:                 allStop.set(null, true);
>>> 199:             } catch (IllegalArgumentException| IllegalAccessException ex) {
>>> 200:                 throw new InternalException(ex.getMessage());
>> 
>> to avoid to drop the stack trace of the original exception, it's better to chain the exceptions,
>> 
>>   throw (InternalException) new InternalException().initCause(ex);
>
> I just followed similar pattern as in other 9 cases of throwing new InternalException in idk.jshell.

Adjusted exception message construction to exactly match other cases.

-------------

PR: https://git.openjdk.org/jdk/pull/10166


More information about the core-libs-dev mailing list