RFR: 8293910: tools/launcher/FXLauncherTest.java fail with jfx

[Leslie Zhai]

On Fri, 16 Sep 2022 07:35:03 GMT, Leslie Zhai <lzhai at openjdk.org> wrote:

> Hi,
> 
> @dumasun reported the issue:
> 
> Configured with jfx-ls-modular-sdk:
> 
> 
> configure --with-import-modules=modular-sdk
> 
> 
> `make run-test CONF=fastdebug TEST="tools/launcher/FXLauncherTest.java"` failed:
> 
> 
> ----------System.err:(11/697)----------
> java.lang.RuntimeException: JavaFX modules erroneously included in the JDK
>     at FXLauncherTest.main(FXLauncherTest.java:451)
>     at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
>     at java.base/java.lang.reflect.Method.invoke(Method.java:578)
>     at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127)
>     at java.base/java.lang.Thread.run(Thread.java:1589)
> 
> JavaTest Message: Test threw exception: java.lang.RuntimeException: JavaFX modules erroneously included in the JDK
> JavaTest Message: shutting down test
> 
> STATUS:Failed.`main' threw exception: java.lang.RuntimeException: JavaFX modules erroneously included in the JDK
> 
> 
> Thanks,
> Leslie Zhai

Hi,

Thank @kevinrushforth [8202553: Update FXLauncherTest as part of removing JavaFX from JDK](https://github.com/openjdk/jdk/commit/8af434d695ca2f8da8fcdbbf058b85d4e79fbd1a).  And jdk11u-dev Passed:


make run-test CONF=fastdebug TEST="tools/launcher/FXLauncherTest.java"

==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR   
   jtreg:test/jdk/tools/launcher/FXLauncherTest.java     1     1     0     0   
==============================
TEST SUCCESS


So I just skip the test for configured with jfx-ls-modular-sdk.

Please review my patch.

Thanks,
Leslie Zhai

-------------

PR: https://git.openjdk.org/jdk/pull/10299