RFR: 8293910: tools/launcher/FXLauncherTest.java fail with jfx

[Alan Bateman]

On Fri, 16 Sep 2022 07:35:03 GMT, Leslie Zhai <lzhai at openjdk.org> wrote:

> Hi,
> 
> @dumasun reported the issue:
> 
> Configured with jfx-ls-modular-sdk:
> 
> 
> configure --with-import-modules=modular-sdk
> 
> 
> `make run-test CONF=fastdebug TEST="tools/launcher/FXLauncherTest.java"` failed:
> 
> 
> ----------System.err:(11/697)----------
> java.lang.RuntimeException: JavaFX modules erroneously included in the JDK
>     at FXLauncherTest.main(FXLauncherTest.java:451)
>     at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
>     at java.base/java.lang.reflect.Method.invoke(Method.java:578)
>     at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127)
>     at java.base/java.lang.Thread.run(Thread.java:1589)
> 
> JavaTest Message: Test threw exception: java.lang.RuntimeException: JavaFX modules erroneously included in the JDK
> JavaTest Message: shutting down test
> 
> STATUS:Failed.`main' threw exception: java.lang.RuntimeException: JavaFX modules erroneously included in the JDK
> 
> 
> Thanks,
> Leslie Zhai

Can you try the following:

1. Change doFxCompile and doFxExec to use --upgrade-module-path instead of --module-path?
2. Remove the check for javafx.application.Application from the main method.

It would be interesting to check if it passes with regular builds of the JDK and your build that includes the JavaFX modules.

Note that the test summary includes the sentence "It also verifies that FX is, in fact, not included with the JDK" so that will need to change if the test is changed.

-------------

PR: https://git.openjdk.org/jdk/pull/10299