RFR: 8293991: java/lang/Float/Binary16ConversionNaN.java fails on silent NaN conversions [v2]

Aleksey Shipilev shade at openjdk.org
Thu Sep 22 18:48:41 UTC 2022


On Thu, 22 Sep 2022 16:41:53 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>> 
>>  - Just exclude the test with x87
>>  - Revert test
>>  - Merge branch 'master' into JDK-8293991-x86-32-fp16
>>  - Indenting
>>  - Fix
>
> test/jdk/java/lang/Float/Binary16ConversionNaN.java line 27:
> 
>> 25:  * @test
>> 26:  * @bug 8289551
>> 27:  * @library /test/lib
> 
> If we want to simply not run this test on x87, that could be done using jtreg @requires tags. For example
> 
> * @requires vm.bits == "64"
> 
> if this is only an issue for 32-bit x86 or something based on requiring os.arch values.
> 
> The companion test [Binary16Conversion.java](https://github.com/openjdk/jdk/blob/master/test/jdk/java/lang/Float/Binary16Conversion.java) tests the NaN handling contract required by the specification.

Oh, I did not realize other tests verify `NaN` works. I tried to salvage this test thinking we still need to test at least some `NaN`-s. Since there is no apparent need for that, let's just exclude the test on x87. See new commit.

-------------

PR: https://git.openjdk.org/jdk/pull/10333


More information about the core-libs-dev mailing list