RFR: 8293991: java/lang/Float/Binary16ConversionNaN.java fails on silent NaN conversions [v2]

Joe Darcy darcy at openjdk.org
Thu Sep 22 20:14:21 UTC 2022


On Thu, 22 Sep 2022 18:43:40 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> test/jdk/java/lang/Float/Binary16ConversionNaN.java line 27:
>> 
>>> 25:  * @test
>>> 26:  * @bug 8289551
>>> 27:  * @library /test/lib
>> 
>> If we want to simply not run this test on x87, that could be done using jtreg @requires tags. For example
>> 
>> * @requires vm.bits == "64"
>> 
>> if this is only an issue for 32-bit x86 or something based on requiring os.arch values.
>> 
>> The companion test [Binary16Conversion.java](https://github.com/openjdk/jdk/blob/master/test/jdk/java/lang/Float/Binary16Conversion.java) tests the NaN handling contract required by the specification.
>
> Oh, I did not realize other tests verify `NaN` works. I tried to salvage this test thinking we still need to test at least some `NaN`-s. Since there is no apparent need for that, let's just exclude the test on x87. See new commit.

Right; anticipating the possibility of platform-specific NaN handling, I split out the bit-specific NaN tests into a separate file so just those NaN bit could have @requires tags while keeping most of the float16 conversion tests running on all platforms :-)

-------------

PR: https://git.openjdk.org/jdk/pull/10333


More information about the core-libs-dev mailing list