RFR: 8293462: [macos] app image signature invalid when creating DMG or PKG from post processed signed image [v2]

Alexey Semenyuk asemenyuk at openjdk.org
Fri Sep 23 20:54:17 UTC 2022


On Tue, 20 Sep 2022 04:05:56 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:

>> Problem is that [JDK-8286850](https://bugs.openjdk.org/browse/JDK-8286850) never set correct value in .jpackage.xml to mark image as signed. [JDK-8289030](https://bugs.openjdk.org/browse/JDK-8289030) reads this value to check if we can add per-user and system wide configuration to packaged app. Fixed by setting correct value in .jpackage.xml when we signing predefine application image.
>> 
>> Added tests to cover this case and added check for values inside .jpackage.xml to validate signed and Mac App Store values.
>
> Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8293462: [macos] app image signature invalid when creating DMG or PKG from post processed signed image [v2]

Changes requested by asemenyuk (Reviewer).

src/jdk.jpackage/share/classes/jdk/jpackage/internal/AppImageFile.java line 64:

> 62: 
> 63:     // These values will be loaded from AppImage xml file.
> 64:     private final Path appImageDir;

What this field is for? This property doesn't belong to the class.

-------------

PR: https://git.openjdk.org/jdk/pull/10316


More information about the core-libs-dev mailing list