RFR: 8293462: [macos] app image signature invalid when creating DMG or PKG from post processed signed image [v2]

Alexey Semenyuk asemenyuk at openjdk.org
Mon Sep 26 19:35:33 UTC 2022


On Mon, 26 Sep 2022 19:28:38 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:

>> src/jdk.jpackage/share/classes/jdk/jpackage/internal/AppImageFile.java line 64:
>> 
>>> 62: 
>>> 63:     // These values will be loaded from AppImage xml file.
>>> 64:     private final Path appImageDir;
>> 
>> What this field is for? This property doesn't belong to the class.
>
> It was used to show path to .jpackage.xml file in case of error from copyAsSigned(), but it is actually not needed, since copyAsSigned() should not produce invalid app image file.

If not used, then I'd remove it.

-------------

PR: https://git.openjdk.org/jdk/pull/10316


More information about the core-libs-dev mailing list