RFR: 8305846: Support compilation in Proc test utility

[David Holmes]

On Tue, 11 Apr 2023 13:40:39 GMT, Weijun Wang <weijun at openjdk.org> wrote:

> Enhance the `Proc` utility to support compilation.

test/lib/jdk/test/lib/process/Proc.java line 274:

> 272:     }
> 273:     // Compile as well
> 274:     public Proc compile() throws IOException {

Why "throws IOException" ? I'm surprised javac doesn't say it can't be thrown.

test/lib/jdk/test/lib/process/Proc.java line 286:

> 284:         if (cp == null) {
> 285:             return System.getProperty("test.class.path") + File.pathSeparator +
> 286:                     System.getProperty("test.src.path");

Pre-existing by why is the src path put in the classpath?

test/lib/jdk/test/lib/process/Proc.java line 338:

> 336:             if (!comp) {
> 337:                 throw new IOException("Compilation error");
> 338:             }

Seems an odd use of IOException and not very helpful - will the actual compile command produce any diagnostics?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13425#discussion_r1163516184
PR Review Comment: https://git.openjdk.org/jdk/pull/13425#discussion_r1163517536
PR Review Comment: https://git.openjdk.org/jdk/pull/13425#discussion_r1163518613