RFR: 8305846: Support compilation in Proc test utility

[David Holmes]

On Tue, 11 Apr 2023 13:40:39 GMT, Weijun Wang <weijun at openjdk.org> wrote:

> Enhance the `Proc` utility to support compilation.

test/lib/jdk/test/lib/process/Proc.java line 331:

> 329: 
> 330:         if (compile) {
> 331:             var comp = CompilerUtils.compile(

I don't find this use of `var` helpful - `var` is useful for saying "some type I don't really care about and can't be bothered to spell out". But here we just have a boolean so it is clearer to just say `boolean compiled` (or `success` or `ok` or some such name that reflects what the return value actually means). Thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13425#discussion_r1163528639