RFR: 8306038: SystemModulesPlugin: Keep stack clean

Alan Bateman alanb at openjdk.org
Mon Apr 17 08:24:32 UTC 2023


On Wed, 12 Apr 2023 09:18:13 GMT, Oliver Kopp <duke at openjdk.org> wrote:

> This refs [https://bugs.openjdk.org/browse/JDK-8306038](8306038). 
> 
> (Before this referenced 8240567)
> 
> Although this change is rather small, I think, it's good to have a "more clean" SystemModulesPlugin available.

This looks okay.

This looks right. I assume you've checked  `java -XX:+UnlockDiagnosticVMOptions  -XX:+BytecodeVerificationLocal -version` as this code is not normally verified. Also I assume you've run tier2 with the jlink tests.

You will need to edit the PR so it matches the JBS title.

@mlchung @asotona, do you want to look at this too? I think it pre-dates the conversion to the class file API.

-------------

Marked as reviewed by alanb (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13442#pullrequestreview-1387522396
PR Comment: https://git.openjdk.org/jdk/pull/13442#issuecomment-1510912251


More information about the core-libs-dev mailing list