RFR: 8306038: SystemModulesPlugin: Keep stack clean

[Oliver Kopp]

On Mon, 17 Apr 2023 08:21:11 GMT, Alan Bateman <alanb at openjdk.org> wrote:

> This looks right. I assume you've checked `java -XX:+UnlockDiagnosticVMOptions -XX:+BytecodeVerificationLocal -version` as this code is not normally verified


koppor at DESKTOP-KAK953S /cygdrive/c/git-repositories/jdk/jdk/build/windows-x86_64-server-release/jdk/bin
$ ./java -XX:+UnlockDiagnosticVMOptions  -XX:+BytecodeVerificationLocal -version
openjdk version "21-internal" 2023-09-19
OpenJDK Runtime Environment (build 21-internal-adhoc.koppor.jdk)
OpenJDK 64-Bit Server VM (build 21-internal-adhoc.koppor.jdk, mixed mode)


> Also I assume you've run tier2 with the jlink tests.

TBH, I assumed there is a CI in place checking `tier2`, too.

Locally, they do not run here. Example:


test ZipFileSystemTest.testInvalidRequestURIGET(): failure
java.lang.AssertionError: expected [134] but found [146]
        at org.testng.Assert.fail(Assert.java:99)
        at org.testng.Assert.failNotEquals(Assert.java:1037)
        at org.testng.Assert.assertEqualsImpl(Assert.java:140)
...
JavaTest Message: Test threw exception: java.lang.RuntimeException: javax.security.auth.login.LoginException: F?r NT sind keine LoginModules konfiguriert
JavaTest Message: shutting down test


I assume, I should run the test on a dedicated linux machine?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13442#issuecomment-1512755693