RFR: 8305990: Stripping debug info of ASM 9.5 fails [v2]

[Chen Liang]

On Wed, 19 Apr 2023 13:06:20 GMT, Adam Sotona <asotona at openjdk.org> wrote:

>> Classfile API didn't handle transformations of class files version 50 and below correctly. 
>> 
>> Proposed fix have two parts: 
>> 1. Inflation of branch targets does not depend on StackMapTable attribute presence for class file version 50 and below. Alternative fallback implementation is provided. 
>> 2. StackMapTable attribute is not generated for class file versions below 50.
>> 
>> StackMapsTest is also extended to test this patch.
>> 
>> Please review.
>> 
>> Thanks,
>> Adam
>
> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
> 
>   DiscontinuedInstruction implementation + test

src/java.base/share/classes/jdk/internal/classfile/impl/DirectCodeBuilder.java line 343:

> 341:                 }
> 342:                 else {
> 343:                     maxStack = maxLocals = 255;

Will this have a negative effect, such as slowing down the vm at runtime?

Edit: sorry, didn't see your summary comment when I was reviewing the updated patch. Otherwise it looks all good!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13478#discussion_r1171348201