RFR: 8305990: Stripping debug info of ASM 9.5 fails [v2]

Adam Sotona asotona at openjdk.org
Thu Apr 20 17:07:13 UTC 2023


On Wed, 19 Apr 2023 13:30:44 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   DiscontinuedInstruction implementation + test
>
> src/java.base/share/classes/jdk/internal/classfile/impl/DirectCodeBuilder.java line 343:
> 
>> 341:                 }
>> 342:                 else {
>> 343:                     maxStack = maxLocals = 255;
> 
> Will this have a negative effect, such as slowing down the vm at runtime?
> 
> Edit: sorry, didn't see your summary comment when I was reviewing the updated patch. Otherwise it looks all good!

I've implemented StackCounter as a simple alternative to StackMapGenerator

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13478#discussion_r1172871858


More information about the core-libs-dev mailing list