RFR: 8313657 : com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors [v3]

[Vyom Tewari]

On Fri, 4 Aug 2023 19:09:58 GMT, Weibing Xiao <duke at openjdk.org> wrote:

>> com.sun.jndi.ldap.Connection::leanup does not close the underlying socket if the is an IOException generation when the output stream was flushing the buffer.
>> 
>> Please refer to the bug https://bugs.openjdk.org/browse/JDK-8313657.
>
> Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update error message

src/java.naming/share/classes/com/sun/jndi/ldap/Connection.java line 686:

> 684: 
> 685:     // flush and close output stream
> 686:     private void flushCloseOutputStream() {

'flushAndCloseOutputStream' will be more meaningful name.

src/java.naming/share/classes/com/sun/jndi/ldap/Connection.java line 702:

> 700: 
> 701:     // close socket
> 702:     private void closeConnectionSocket() {

'closeSocketConnection' will be more meaningful.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15143#discussion_r1285437029
PR Review Comment: https://git.openjdk.org/jdk/pull/15143#discussion_r1285438547