RFR: 8313657 : com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors [v3]
Mark Sheppard
msheppar at openjdk.org
Mon Aug 7 08:57:32 UTC 2023
On Mon, 7 Aug 2023 06:42:54 GMT, Vyom Tewari <vtewari at openjdk.org> wrote:
>> Weibing Xiao has updated the pull request incrementally with one additional commit since the last revision:
>>
>> update error message
>
> src/java.naming/share/classes/com/sun/jndi/ldap/Connection.java line 702:
>
>> 700:
>> 701: // close socket
>> 702: private void closeConnectionSocket() {
>
> 'closeSocketConnection' will be more meaningful.
the suggested name was to convey the closing of the Connection's socket, not a socket connection per se.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15143#discussion_r1285577687
More information about the core-libs-dev
mailing list