RFR: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview) [v10]

Martin Doerr mdoerr at openjdk.org
Mon Aug 7 13:40:39 UTC 2023


On Tue, 1 Aug 2023 06:29:28 GMT, sid8606 <duke at openjdk.org> wrote:

>> Implementation of "Foreign Function & Memory API" for s390x (Big Endian).
>
> sid8606 has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix typo
>   
>   Signed-off-by: Sidraya <sidraya.jayagond at ibm.com>

src/hotspot/cpu/s390/foreignGlobals_s390.cpp line 154:

> 152:       } else {
> 153:         assert(to_reg.stack_size() == 4, "size should match");
> 154:         // s390 needs 4 Byte offset

Seems like this comment should get removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14801#discussion_r1285880721


More information about the core-libs-dev mailing list