RFR: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview) [v10]

[sid8606]

On Mon, 7 Aug 2023 13:37:57 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> sid8606 has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix typo
>>   
>>   Signed-off-by: Sidraya <sidraya.jayagond at ibm.com>
>
> src/hotspot/cpu/s390/foreignGlobals_s390.cpp line 154:
> 
>> 152:       } else {
>> 153:         assert(to_reg.stack_size() == 4, "size should match");
>> 154:         // s390 needs 4 Byte offset
> 
> Seems like this comment should get removed.

Fixed

> src/java.base/share/classes/jdk/internal/foreign/abi/s390/linux/LinuxS390CallArranger.java line 221:
> 
>> 219:                     Class<?> type = SharedUtils.primitiveCarrierForSize(layout.byteSize(), false);
>> 220:                     bindings.bufferLoad(0, type)
>> 221:                         .vmStore(storage, type);
> 
> Maybe improve indentation?

Thank you @TheRealMDoerr. Fixed in new commit.

> src/java.base/share/classes/jdk/internal/foreign/abi/s390/linux/TypeClass.java line 44:
> 
>> 42:     FLOAT;
>> 43: 
>> 44:     private static final int MAX_AGGREGATE_REGS_SIZE = 1;
> 
> Unused.

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14801#discussion_r1286613915
PR Review Comment: https://git.openjdk.org/jdk/pull/14801#discussion_r1286613616
PR Review Comment: https://git.openjdk.org/jdk/pull/14801#discussion_r1286613721