RFR: 8288899: java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted" [v4]

[Doug Lea]

On Thu, 17 Aug 2023 09:50:49 GMT, Viktor Klang <duke at openjdk.org> wrote:

>> Doug Lea has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 45 additional commits since the last revision:
>> 
>>  - Merge branch 'openjdk:master' into JDK-8288899
>>  - Update @since tags
>>  - resync
>>  - Merge branch 'openjdk:master' into JDK-8288899
>>  - ExecutorService tests
>>  - Merge branch 'openjdk:master' into JDK-8288899
>>  - Rework versioning
>>  - Merge branch 'openjdk:master' into JDK-8288899
>>  - Merge branch 'openjdk:master' into JDK-8288899
>>  - Merge branch 'openjdk:master' into JDK-8288899
>>  - ... and 35 more: https://git.openjdk.org/jdk/compare/31d0f5ed...585769c9
>
> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 456:
> 
>> 454:      * mechanism. In particular, the stack top subfield of ctl stores
>> 455:      * indices, not references. Operations on queues obtained from
>> 456:      * these indices remain OK (with at most some unnecessary extra
> 
> Suggestion:
> 
>      * these indices remain valid (with at most some unnecessary extra

Thanks. Done

> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 721:
> 
>> 719:      * they are ignored, and 0 is an OK default.) The scan in method
>> 720:      * helpJoin uses these markers to try to find a worker to help
>> 721:      * (i.e., steal back a task from and execute it) that could makje
> 
> Suggestion:
> 
>      * (i.e., steal back a task from and execute it) that could make

Thanks. Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14301#discussion_r1297228886
PR Review Comment: https://git.openjdk.org/jdk/pull/14301#discussion_r1297229368