RFR: 8321159: SymbolLookup.libraryLookup(Path, Arena) Assumes default Filesystem [v3]
Jorn Vernee
jvernee at openjdk.org
Mon Dec 4 15:05:48 UTC 2023
On Mon, 4 Dec 2023 09:10:07 GMT, Per Minborg <pminborg at openjdk.org> wrote:
>> This PR proposes to reject paths provided to the `SymbolLookup.libraryLookup(Path path, Arena arena)` method if a path is not in the default file system.
>
> Per Minborg has updated the pull request incrementally with one additional commit since the last revision:
>
> Add fail statement
src/java.base/share/classes/java/lang/foreign/SymbolLookup.java line 288:
> 286: * is called from a thread {@code T}, other than the arena's owner thread
> 287: * @throws IllegalArgumentException if {@code path} is not in the default file system
> 288: * or if {@code path} does not point to a valid library
Please split this into separate `@throws IllegalArgumentException` tags, as that is what we do everywhere else in the FFM API.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16944#discussion_r1414029801
More information about the core-libs-dev
mailing list