RFR: 8321159: SymbolLookup.libraryLookup(Path, Arena) Assumes default Filesystem [v3]

[Alan Bateman]

On Mon, 4 Dec 2023 15:00:56 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Per Minborg has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add fail statement
>
> src/java.base/share/classes/java/lang/foreign/SymbolLookup.java line 288:
> 
>> 286:      *         is called from a thread {@code T}, other than the arena's owner thread
>> 287:      * @throws IllegalArgumentException if {@code path} is not in the default file system
>> 288:      *         or if {@code path} does not point to a valid library
> 
> Please split this into separate `@throws IllegalArgumentException` tags, as that is what we do everywhere else in the FFM API.

It depends on the wording. If changed to something like "not a path to a valid library in the default file system" then it avoid describing it as two cases.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16944#discussion_r1414118698