RFR: 8310813: Simplify and modernize equals, hashCode, and compareTo for BigInteger [v8]
Pavel Rappo
prappo at openjdk.org
Thu Dec 14 10:13:47 UTC 2023
On Tue, 7 Nov 2023 07:58:40 GMT, Pavel Rappo <prappo at openjdk.org> wrote:
>> Please review this PR to use modern APIs and language features to simplify equals, hashCode, and compareTo for BigInteger. If you have any performance concerns, please raise them.
>>
>> This PR is cherry-picked from a bigger, not-yet-published PR, to test the waters. That latter PR will be published soon.
>
> Pavel Rappo has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 15 additional commits since the last revision:
>
> - Merge branch 'master' into 8310813
> - Merge branch 'master' into 8310813
> - Fix bugs in Shared.createSingle
> - Merge branch 'master' into 8310813
> - Group params coarser (suggested by @cl4es)
>
> - Splits 20 params into 3 groups: (S)mall, (M)edium and (L)arge.
> Every testXYZ method invokes M operations, where M is the maximum
> number of elements in a group. Shorter groups are cyclically padded.
> - Uses the org.openjdk.jmh.infra.Blackhole API and increases
> benchmark time.
> - Fixes a bug in Shared that precluded 0 from being in a pair.
> - Use better overloads (suggested by @cl4es)
>
> - Uses simpler, more suitable overloads for the subrange
> starting from 0
> - Improve benchmarks
> - Merge branch 'master' into 8310813
> - Restore hash code values
>
> BigInteger is old and ubiquitous enough so that there might be
> inadvertent dependencies on its hash code.
>
> This commit also includes a test, to make sure hash code is
> unchanged.
> - Merge branch 'master' into 8310813
> - ... and 5 more: https://git.openjdk.org/jdk/compare/5a26cc03...155fedba
Dear reviewers, what do you think about that performance data I recently published?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/14630#issuecomment-1855554882
More information about the core-libs-dev
mailing list