RFR: 8320971: Use BufferedInputStream.buf directly when param of implTransferTo() is trusted [v15]
Markus KARG
duke at openjdk.org
Sat Dec 30 19:02:46 UTC 2023
On Sun, 17 Dec 2023 09:06:58 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Sergey Tsypanov has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8320971: Revert irrelevant changes
>
> For the method description, I think you can expand it to:
>
> - does not retain a reference to the byte[]
> - does not leak a reference to the byte[] to non-trusted classes
> - does not modify the contents of the byte[]
> - its 3-arg write does not read the contents outside of the offset/length bounds
>
> In passing, this class uses "out" for the target OutputStream in the other methods, you can keep that consistent. Also I assume the `@see` are left over from a previous iteration.
@AlanBateman Kindly requesting your review. :-)
-------------
PR Comment: https://git.openjdk.org/jdk/pull/16879#issuecomment-1872584495
More information about the core-libs-dev
mailing list